Patchwork [Open-FCoE,trivial] fcoe: use defines from ethtool for 20Gbit and 40Gbit speeds

login
register
mail settings
Submitter Johannes Thumshirn
Date July 7, 2016, 1:41 p.m.
Message ID <1467898918-90352-1-git-send-email-jthumshirn@suse.de>
Download mbox | patch
Permalink /patch/332/
State New
Headers show

Comments

Johannes Thumshirn - July 7, 2016, 1:41 p.m.
Use defines from ethtool for 20Gbit and 40Gbit speeds instead of magic
numbers.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
 drivers/scsi/fcoe/fcoe_transport.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Laurence Oberman - July 7, 2016, 3:34 p.m.
----- Original Message -----
> From: "Johannes Thumshirn" <jthumshirn@suse.de>
> To: "Martin K . Petersen" <martin.petersen@oracle.com>, "James Bottomley" <jejb@linux.vnet.ibm.com>, "Jiri Kosina"
> <trivial@kernel.org>
> Cc: "Linux SCSI Mailinglist" <linux-scsi@vger.kernel.org>, fcoe-devel@open-fcoe.org, "Johannes Thumshirn"
> <jthumshirn@suse.de>
> Sent: Thursday, July 7, 2016 9:41:58 AM
> Subject: [PATCH trivial] fcoe: use defines from ethtool for 20Gbit and 40Gbit speeds
> 
> Use defines from ethtool for 20Gbit and 40Gbit speeds instead of magic
> numbers.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
>  drivers/scsi/fcoe/fcoe_transport.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/fcoe/fcoe_transport.c
> b/drivers/scsi/fcoe/fcoe_transport.c
> index 641c60e..7028dd3 100644
> --- a/drivers/scsi/fcoe/fcoe_transport.c
> +++ b/drivers/scsi/fcoe/fcoe_transport.c
> @@ -133,10 +133,10 @@ int fcoe_link_speed_update(struct fc_lport *lport)
>  		case SPEED_10000:
>  			lport->link_speed = FC_PORTSPEED_10GBIT;
>  			break;
> -		case 20000:
> +		case SPEED_20000:
>  			lport->link_speed = FC_PORTSPEED_20GBIT;
>  			break;
> -		case 40000:
> +		case SPEED_40000:
>  			lport->link_speed = FC_PORTSPEED_40GBIT;
>  			break;
>  		default:
> --
> 1.8.5.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Looks fine, simple change
Reviewed-by: Laurence Oberman <loberman@redhat.com>

Patch

diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
index 641c60e..7028dd3 100644
--- a/drivers/scsi/fcoe/fcoe_transport.c
+++ b/drivers/scsi/fcoe/fcoe_transport.c
@@ -133,10 +133,10 @@  int fcoe_link_speed_update(struct fc_lport *lport)
 		case SPEED_10000:
 			lport->link_speed = FC_PORTSPEED_10GBIT;
 			break;
-		case 20000:
+		case SPEED_20000:
 			lport->link_speed = FC_PORTSPEED_20GBIT;
 			break;
-		case 40000:
+		case SPEED_40000:
 			lport->link_speed = FC_PORTSPEED_40GBIT;
 			break;
 		default: